Refactored the code #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do pass the checks!! |
I don't know what these checks means .. |
|
@vngarg You need to read why. As simple as that. Update: I had a quick look at the failing tests and tried to run the code from your branch. It doesn't compile or run as well. If you see the fail details, it says you why it failed and how to fix them. |
|
I tried but can't find more errors, I could just resolve one error. |
|
I'm closing this PR as you've raised another one. We'll discuss there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had added a helper/Validation.js file with the functions for validation and had also refactored the code in Statefull and Stateless components.
this PR closes the issue #68