Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as done icon added #140

Merged
merged 12 commits into from
Apr 26, 2020
Merged

Mark as done icon added #140

merged 12 commits into from
Apr 26, 2020

Conversation

aditianshu
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 20, 2020

Deploy preview for footsteps-app ready!

Built with commit 75fb3e3

https://deploy-preview-140--footsteps-app.netlify.app

@aditianshu aditianshu closed this Apr 21, 2020
@xlogix
Copy link
Member

xlogix commented Apr 21, 2020

Need some help over here?

@aditianshu
Copy link
Contributor Author

The code review was failing. The blocks {} used while importing Rows, Columns and other components from Ant were declared not useful but it can't be done without the parenthesis, importing them individually didn't work either.
How should I go about it?

@xlogix xlogix reopened this Apr 24, 2020
@xlogix xlogix added easy For Contributors gssoc20 For GSSoC Contributions labels Apr 24, 2020
@xlogix
Copy link
Member

xlogix commented Apr 25, 2020

@aditianshu This is fine. We can merge it. Please push the changes here. #52

@xlogix
Copy link
Member

xlogix commented Apr 26, 2020

Can you remove the two cache folders that have been added? they start with reduxcache...

@xlogix
Copy link
Member

xlogix commented Apr 26, 2020

thanks!

@xlogix xlogix merged commit 24ba70a into fnplus:master Apr 26, 2020
@aditianshu
Copy link
Contributor Author

Thank you! :)

@aditianshu aditianshu deleted the patch-1 branch April 26, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy For Contributors gssoc20 For GSSoC Contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants