Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Mark as Done' icon on a Footstep #52

Closed
xlogix opened this issue Mar 1, 2020 · 20 comments
Closed

Add 'Mark as Done' icon on a Footstep #52

xlogix opened this issue Mar 1, 2020 · 20 comments
Assignees
Labels
easy For Contributors enhancement New feature or request gssoc20 For GSSoC Contributions

Comments

@xlogix
Copy link
Member

xlogix commented Mar 1, 2020

We're working on adding a progress bar on a learning path. A progress bar can only 'progress' if the user is able to select the Footstep(s) and mark them as 'done'.

Refer to issue #17

@xlogix xlogix added easy For Contributors gssoc20 For GSSoC Contributions labels Mar 1, 2020
@xlogix xlogix added the enhancement New feature or request label Mar 1, 2020
@Samriddhi25
Copy link

I would like to take this task

@xlogix
Copy link
Member Author

xlogix commented Mar 3, 2020

Assigned!

@xlogix xlogix changed the title Add 'Mark as Done' icon on a Footstep (link) Add 'Mark as Done' icon on a Footstep Mar 3, 2020
@aditianshu
Copy link
Contributor

@xlogix this issue is necessary for another issue I'm assigned for, the issue has been dormant for long, can I be assigned if it's okay?

@xlogix xlogix assigned aditianshu and unassigned Samriddhi25 Apr 19, 2020
@xlogix
Copy link
Member Author

xlogix commented Apr 19, 2020

Go ahead!

@aditianshu
Copy link
Contributor

image

@xlogix is this okay?

@xlogix
Copy link
Member Author

xlogix commented Apr 20, 2020

Can we add a Fab (with check icon) on the side so this button doesn't take unnecessary space? See the possibilities in Ant Design

@aditianshu
Copy link
Contributor

Okay, I'll check it out.

@aditianshu
Copy link
Contributor

aditianshu commented Apr 20, 2020

image
@xlogix
FAB wasn't available in the design module, I've added a button.

@xlogix
Copy link
Member Author

xlogix commented Apr 20, 2020

Alright. maybe you can make it bigger and keep it on the right? Make it half-way on the card and half outside... maybe that'll look better

@aditianshu
Copy link
Contributor

@xlogix done!
Made a PR.

@xlogix
Copy link
Member Author

xlogix commented Apr 20, 2020

Can you put up a screenshot?

@aditianshu
Copy link
Contributor

image
@xlogix
The tick looked out of place when below the arrow of visit website therefore it's in the extreme right. I reduced the size of the description a bit, as I had to fit it.

@aditianshu
Copy link
Contributor

Also, I had an issue with the checks, could you help me with it?😅

@xlogix
Copy link
Member Author

xlogix commented Apr 21, 2020

Let's move it to the top right? The bottom looks a bit more cluttered. @R3l3ntl3ss Any ideas?

@D3vd
Copy link
Member

D3vd commented Apr 22, 2020

Moving it to somewhere in the top sounds good to me.

@aditianshu
Copy link
Contributor

image

@xlogix how about this? Next to the title. Looks neat.

@xlogix
Copy link
Member Author

xlogix commented Apr 24, 2020

Can you just add a green background to the icon?
image (1)

Also, convert all the shadows in the page to:

  • Blur: 17px
  • Color: #222222
  • Opacity: 9% or 11%

@aditianshu
Copy link
Contributor

image

Added the background and modified the shadows

@xlogix
Copy link
Member Author

xlogix commented Apr 25, 2020

Awesome @aditianshu. Have you pushed the changes in the PR you raised?

@aditianshu
Copy link
Contributor

I've pushed the changes in the PR

@xlogix xlogix closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy For Contributors enhancement New feature or request gssoc20 For GSSoC Contributions
Projects
None yet
Development

No branches or pull requests

4 participants