Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(A380X/MFD): Fixed the crossing climb/descent speed limit pseudo-waypoint label on the A380X #9738

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bulenteroglu
Copy link
Contributor

@bulenteroglu bulenteroglu commented Jan 9, 2025

Summary of Changes

  • Add LIM_PSEUDO_WPT_LABEL to AircraftConfig.VnavConfig

  • Depending on the aircraft type, use the correct ident for the pseudo-waypoint that mark where the aircraft crosses climb/descent speed limit altitudes

Screenshots (if necessary)

Climb A380
Screenshot 2025-01-09 202102
Descent A380
Screenshot 2025-01-09 202109
Climb A320
Screenshot 2025-01-09 203942
Descent A320
Screenshot 2025-01-09 204051

References

image

Additional context

Discord username (if different from GitHub): senolitam

Testing instructions

Enter a full flight plan with INIT-B completed to have predictions. Then check the crossing/descending climb speed pseudo waypoint in the MCDU/MFD.

Test in both aircrafts (A320 & A380)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@bulenteroglu bulenteroglu changed the title fix:add condition to check if a380 to pick correct ident fix: add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt Jan 9, 2025
@bulenteroglu bulenteroglu changed the title fix: add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt fix(a380x/mfd): add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt Jan 9, 2025
* climb/descent speed limit altitudes.
* Configurable since different Airbus aircraft use different labels (e.g. A320 vs A380).
*/
LIM_PSEUDO_WPT_LABEL: '(LIM)' | '(SPDLIM)';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for string literal types but more than happy to change it to string if the team prefers it 👍🏼

@bulenteroglu bulenteroglu marked this pull request as ready for review January 9, 2025 22:28
@bulenteroglu bulenteroglu changed the title fix(a380x/mfd): add condition for a380 to pick correct ident for CrossingClimbSpeedLimit/CrossingDescentSpeedLimit pseudo wpt fix(A380X/MFD): Fixed the crossing climb/descent speed limit pseudo-waypoint label on the A380X Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant