Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/mfd): Use slashed zero as default font for FMS pages #9732

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

bulenteroglu
Copy link
Contributor

Fixes #9731

Summary of Changes

Updated styles to use slashed zero font in the MFD F-PLN pages

Screenshots (if necessary)

image

References

image

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Add FROM/TO
  2. Add CRZ FL and CI
  3. View F-PLN page

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added FMS QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 7, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As this changes the font for nearly every label inside the MFD, could you please have a look through all of the pages to see whether this doesn't introduce unwanted side effects? Some special fields (e.g. callsign in the upper right) should still use the non-strike-trough font

@bulenteroglu
Copy link
Contributor Author

Thanks! As this changes the font for nearly every label inside the MFD, could you please have a look through all of the pages to see whether this doesn't introduce unwanted side effects? Some special fields (e.g. callsign in the upper right) should still use the non-strike-trough font

image
Seems to be working

@flogross89
Copy link
Contributor

@bulenteroglu Had a look at it myself in the sim - looks good so far! One further thing I noticed, the buttons and drop-down fields also seem to use the strike-through-zero-font, could you also please replace the fonts for them?
Should be classes mfd-button, mfd-context-menu, mfd-footer-message-area, mfd-surv-label, mfd-surv-status-button-label, that should cover everything for now (basically it should be everywhere except the callsign at the top from what I can see)

Reference: https://youtu.be/AI8yFhuEa4Q?si=lGJtH_Cnnbj45_yI&t=5111
image

@bulenteroglu
Copy link
Contributor Author

@bulenteroglu Had a look at it myself in the sim - looks good so far! One further thing I noticed, the buttons and drop-down fields also seem to use the strike-through-zero-font, could you also please replace the fonts for them? Should be classes mfd-button, mfd-context-menu, mfd-footer-message-area, mfd-surv-label, mfd-surv-status-button-label, that should cover everything for now (basically it should be everywhere except the callsign at the top from what I can see)

Reference: https://youtu.be/AI8yFhuEa4Q?si=lGJtH_Cnnbj45_yI&t=5111 image

Added :)

@flogross89
Copy link
Contributor

@bulenteroglu Thanks! Can you load it in your sim one last time and check whether the buttons and dropdown menus display correctly? Then we can merge without QA.

@flogross89 flogross89 added QA Not Required and removed QA Ready to Test QA A380 Only QA only for A380 required labels Jan 9, 2025
@bulenteroglu
Copy link
Contributor Author

@bulenteroglu Thanks! Can you load it in your sim one last time and check whether the buttons and dropdown menus display correctly? Then we can merge without QA.

image
image

@flogross89 flogross89 changed the title style(mfd): update font family in mfd fpln pages fix(a380x/mfd): update font family in mfd fpln pages Jan 9, 2025
@flogross89 flogross89 changed the title fix(a380x/mfd): update font family in mfd fpln pages fix(a380x/mfd): Use slashed zero as default font for FMS pages Jan 9, 2025
@flogross89 flogross89 enabled auto-merge (squash) January 9, 2025 21:19
@flogross89 flogross89 disabled auto-merge January 9, 2025 21:19
@flogross89 flogross89 enabled auto-merge (squash) January 9, 2025 21:26
@flogross89 flogross89 merged commit 0e75fde into flybywiresim:master Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FMS QA Not Required
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

MFD: Missing slashed zero in the F-PLN page
3 participants