fix(a380x/efis): Fix VV pb indicator not turning on when TRK-FPA is selected

[heclak]

Fixes #9520

Summary of Changes

Fix VV pb indicator to account for the FPV shown on the PFD when TRK-FPA is selected.

Screenshots (if necessary)

References

Additional context

The testing instructions in #9520 extend into GA mode indications which shouldn't be in the scope of this PR. Will recommend creating a separate issue for fixing GA mode issues if reproduced.

Discord username (if different from GitHub): Heclak

Testing instructions

1. Check that VV pb is off
2. Press the HDG-V/S/TRK-FPA button to switch to TRK-FPA mode. Check that FPV is shown on PFD and VV pb indicator turns on.
3. Press VV pb to check that VV pb cannot be turned off while TRK-FPA is selected
4. Switch to HDG-V/S mode by pressing the HDG-V/S/TRK-FPA button on the FCU. VV pb indicator should turn off.
5. Press the VV pb to toggle the VV on the PFD. Indicator light on the VV pb should sync with the VV display on the PFD.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

[BlueberryKing]

What happens if

• You're in HDG/VS, VV is off
• Turn on TRK/FPA, VV turns on
• Press the VV button, VV stays on
• Turn back to HDG/VS

The VV would now be on because L:A380X_EFIS_#SIDE_SIMVAR_GROUP#_VV_BUTTON_IS_ON was actually toggled while in TRK/FPA, right? Is this expected?

[heclak]

What happens if

• You're in HDG/VS, VV is off
• Turn on TRK/FPA, VV turns on
• Press the VV button, VV stays on
• Turn back to HDG/VS

The VV would now be on because L:A380X_EFIS_#SIDE_SIMVAR_GROUP#_VV_BUTTON_IS_ON was actually toggled while in TRK/FPA, right? Is this expected?

Yes. This is expected behaviour for this PR at this point. Partly because I can't find any docs to confirm if the pb blocking should occur or not. Another because we had a discussion to not complicate the XML logic when i considered blocking the vv pb via the XML. https://discord.com/channels/738864299392630914/747572666780745828/1317287045890048082

If we can confirm that the VV logic should be blocked/changed in the situation which you mentioned, then a FCU logic rewrite would probably need to occur to avoid putting the logic in the XML. Forcing the L:A380X_EFIS_#SIDE_SIMVAR_GROUP#_VV_BUTTON_IS_ON back to 0 while TRK/FPA is on?

[BlueberryKing]

What happens if

• You're in HDG/VS, VV is off
• Turn on TRK/FPA, VV turns on
• Press the VV button, VV stays on
• Turn back to HDG/VS

The VV would now be on because L:A380X_EFIS_#SIDE_SIMVAR_GROUP#_VV_BUTTON_IS_ON was actually toggled while in TRK/FPA, right? Is this expected?

Yes. This is expected behaviour for this PR at this point. Partly because I can't find any docs to confirm if the pb blocking should occur or not. Another because we had a discussion to not complicate the XML logic when i considered blocking the vv pb via the XML. https://discord.com/channels/738864299392630914/747572666780745828/1317287045890048082

If we can confirm that the VV logic should be blocked/changed in the situation which you mentioned, then a FCU logic rewrite would probably need to occur to avoid putting the logic in the XML. Forcing the L:A380X_EFIS_#SIDE_SIMVAR_GROUP#_VV_BUTTON_IS_ON back to 0 while TRK/FPA is on?

Ok, it makes sense not to worry about it until we know what the logic should be 👍.

[BravoMike99]

Quality Assurance Tester Report

Discord Username : bruno_pt99
Object of testing : #9656
Aircraft : A380X
Tier of Testing : 1
Date : 09/01/2025

Testing Process:
Spawned with VV turned off.
Pressed switched to TRK/FPA through the FCU and verified VV light on ✔️
Pressed VV button on either side and the light remained illuminated ✔️
Switched back to HDG/VS & VV light turned off on both sides ✔️
In HDG/VS, the VV light is synchronized with the VV display on the PFD ✔️

Testing Results:
Passed

Media:

2025-01-09.20-01-41.mp4

[BravoMike99]

Please fix the changelog conflict so we can merge 👍

[heclak]

Please fix the changelog conflict so we can merge 👍

@BravoMike99 Changelog conflict resolved