testsuite: add multiple key job-info lookup tests #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
pr5520_add_back_coverage
branch
from
33d9a68 to
91a9383
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5575 +/- ##
==========================================
- Coverage 83.45% 83.45% -0.01%
==========================================
Files 487 487
Lines 82318 82318
==========================================
- Hits 68701 68695 -6
- Misses 13617 13623 +6 |
garlick
approved these changes
Nov 20, 2023
t/job-info/info_lookup.c
Outdated
| log_msg_exit ("error parsing jobid: %s", argv[1]); | ||
|
|
||
| if (!(keys = json_array ())) | ||
| log_err_exit ("json_array"); |
There was a problem hiding this comment.
jansson functions don't claim to set errno so this should probably use log_msg_exit().
t/job-info/info_lookup.c
Outdated
Comment on lines
45
to
48
| if (!key) | ||
| log_err_exit ("json_string_value"); | ||
| if (json_array_append_new (keys, key) < 0) | ||
| log_err_exit ("json_array_append_new"); |
Problem: In PR flux-framework#5520 "multiple key" "flux job info" tests were removed due to a feature change in "flux job info". This removed some coverage of corner cases in job-info.lookup. Add a new "job-info.lookup" RPC target helper tool and re-add a number of the previously removed "multiple key" tests.
chu11
force-pushed
the
pr5520_add_back_coverage
branch
from
91a9383 to
2423896
Compare
|
thanks! tweaked and setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In PR #5520 "multiple key" "flux job info" tests were removed due to a feature change in "flux job info". This removed some coverage of corner cases in job-info.lookup.
Add a new "job-info.lookup" RPC target helper tool and re-add a number of the previously removed "multiple key" tests.