broker: cleanup up attribute initialization code #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
approved these changes
Nov 10, 2023
| @@ -120,7 +120,7 @@ broker.rc1_path [Updates: C] | |||
| The path to the broker's rc1 script. Default: ``${prefix}/etc/flux/rc1``. | |||
|
|
|||
| broker.rc3_path [Updates: C] | |||
| The path to the broker's rc3 script. Default: ``${prefix}/etc/flux/rc1``. | |||
| The path to the broker's rc3 script. Default: ``${prefix}/etc/flux/rc3``. | |||
There was a problem hiding this comment.
Typo in commit message: s/thes/the/
Problem: there are only two attributes to set from the broker environment now, and the code is more complex than it need be. Simplify code.
Problem: flux-config(1) has a cut and paste error in the blurb on conf.shell_initrc. Correct error.
Problem: flux-broker-attributes(7) has a cut and paste error in the entry for broker.rc3_path. Correct error.
garlick
force-pushed
the
broker_attr_cleanup
branch
from
1fbb87b to
5b329ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #5543 +/- ##
===========================================
+ Coverage 55.36% 83.47% +28.10%
===========================================
Files 439 487 +48
Lines 74728 82299 +7571
===========================================
+ Hits 41375 68697 +27322
+ Misses 33353 13602 -19751
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: after #5536 was merged, the broker code for initializing "attributes from the environment" looks over-engineered.
Trim it down.
Also fix some man page typos that were adjacent to the work in #5536.