Skip to content

Commit

Permalink
testsuite: drop multikey tests for flux job info
Browse files Browse the repository at this point in the history
Problem: there are several tests for flux job info fetching
multiple keys at once, but this feature is to be deprecated.

Drop tests.
  • Loading branch information
garlick committed Oct 27, 2023
1 parent ce603cc commit 8036382
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 82 deletions.
43 changes: 0 additions & 43 deletions t/t2230-job-info-lookup.t
Original file line number Diff line number Diff line change
Expand Up @@ -123,49 +123,6 @@ test_expect_success 'flux job info --base R works' '
| jq -e ".execution.expiration == 0.0"
'

#
# job info lookup tests (multiple info requests)
#

test_expect_success 'flux job info multiple keys works (different keys)' '
jobid=$(submit_job) &&
flux job info $jobid eventlog jobspec J > all_info_a.out &&
grep submit all_info_a.out &&
grep sleep all_info_a.out
'

test_expect_success 'flux job info multiple keys works (same key)' '
jobid=$(submit_job) &&
flux job info $jobid eventlog eventlog eventlog > eventlog_3.out &&
test $(grep submit eventlog_3.out | wc -l) -eq 3
'

test_expect_success 'flux job info multiple keys fails on bad id' '
test_must_fail flux job info 12345 eventlog jobspec J
'

test_expect_success 'flux job info multiple keys fails on 1 bad entry (include eventlog)' '
jobid=$(submit_job) &&
kvsdir=$(flux job id --to=kvs $jobid) &&
flux kvs unlink ${kvsdir}.jobspec &&
test_must_fail flux job info $jobid eventlog jobspec J > all_info_b.out
'

test_expect_success 'flux job info multiple keys fails on 1 bad entry (no eventlog)' '
jobid=$(submit_job) &&
kvsdir=$(flux job id --to=kvs $jobid) &&
flux kvs unlink ${kvsdir}.jobspec &&
test_must_fail flux job info $jobid jobspec J > all_info_b.out
'

# N.B. Issue #5305, jobspec would be output twice, so we check for one
# output of jobspec
test_expect_success 'flux job info --original jobspec and J works' '
jobid=$(flux submit --env=ORIGINALTHING=t true) &&
flux job info --original $jobid J jobspec > J_jobspec_original.out &&
test $(grep ORIGINALTHING J_jobspec_original.out | wc -l) -eq 1
'

#
# job info lookup tests (via eventlog)
#
Expand Down
38 changes: 0 additions & 38 deletions t/t2232-job-info-security.t
Original file line number Diff line number Diff line change
Expand Up @@ -158,44 +158,6 @@ test_expect_success 'flux job info jobspec fails (wrong user)' '
unset_userid
'

test_expect_success 'flux job info multiple keys works (owner, include eventlog)' '
jobid=$(submit_job) &&
flux job info $jobid eventlog jobspec J
'

test_expect_success 'flux job info multiple keys works (user, include eventlog)' '
jobid=$(submit_job 9000) &&
set_userid 9000 &&
flux job info $jobid eventlog jobspec J &&
unset_userid
'

test_expect_success 'flux job info multiple keys fails (wrong user, include eventlog)' '
jobid=$(submit_job 9000) &&
set_userid 9999 &&
! flux job info $jobid eventlog jobspec J &&
unset_userid
'

test_expect_success 'flux job info multiple keys works (owner, no eventlog)' '
jobid=$(submit_job) &&
flux job info $jobid jobspec J
'

test_expect_success 'flux job info multiple keys works (user, no eventlog)' '
jobid=$(submit_job 9000) &&
set_userid 9000 &&
flux job info $jobid jobspec J &&
unset_userid
'

test_expect_success 'flux job info multiple keys fails (wrong user, no eventlog)' '
jobid=$(submit_job 9000) &&
set_userid 9999 &&
! flux job info $jobid jobspec J &&
unset_userid
'

test_expect_success 'flux job info foobar fails (owner)' '
jobid=$(submit_job) &&
! flux job info $jobid foobar
Expand Down
4 changes: 3 additions & 1 deletion t/valgrind/workload.d/job-info
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ set -x
id=$(flux submit -n 1 /bin/true)
flux job attach ${id}

flux job info ${id} eventlog jobspec R >/dev/null
flux job info ${id} eventlog >/dev/null
flux job info ${id} jobspec >/dev/null
flux job info ${id} R >/dev/null

0 comments on commit 8036382

Please sign in to comment.