Document existing orbit auto-uninstall behavior (runs if post-install is supplied and fails, not if install fails) #25300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is supplied and fails, not if install fails) Haven't done full research yet on why this is, but my guess is that if an install fails we don't know at what stage it failed, so running an uninstall script would potentially just break things further. Putting the trigger on post-install means that it's opt-in (we don't populate post-install scripts by default) and we're uninstalling from a relatively known state (the installer didn't error). I'll get an issue filed tomorrow to make sure that this remains the desired behavior, or if not then when we change this (e.g. when implementing patching flows), but might as well fix docs in the interim to be clear about what we're doing.
iansltx
added
the
:improve documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't done full research yet on why this is, but my guess is that if an install fails we don't know at what stage it failed, so running an uninstall script would potentially just break things further. Putting the trigger on post-install means that it's opt-in (we don't populate post-install scripts by default) and we're uninstalling from a relatively known state (the installer didn't error).
I'll get an issue filed tomorrow to make sure that this remains the desired behavior, or if not then when we change this (e.g. when implementing patching flows), but might as well fix docs in the interim to be clear about what we're doing.