Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instability of ubuntu-latest #25289

Closed
wants to merge 1 commit into from
Closed

Fix instability of ubuntu-latest #25289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ jobs:
fail-fast: false
matrix:
# See #9943, we just need to add windows-latest here once all issues are fixed.
os: [ubuntu-latest, macos-latest]
# Pinning to ubuntu-22.04 instead of using ubuntu-latest (updated to 24.04) to fix instability.
os: [ubuntu-22.04, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Harden Runner
Expand All @@ -54,7 +55,7 @@ jobs:
go-version-file: 'go.mod'

- name: Install dependencies (Linux)
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-22.04'
run: |
# The following packages are needed to build Fleet Desktop on Ubuntu.
sudo apt update -y && sudo apt install -y gcc libgtk-3-dev libayatana-appindicator3-dev
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/test-go.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:
strategy:
matrix:
suite: ["integration", "core"]
os: [ubuntu-latest]
# Pinning to 22.04 instead of using ubuntu-latest (updated to 24.04) to fix instability.
os: [ubuntu-22.04]
mysql: ["mysql:8.0.36", "mysql:8.4.3", "mysql:9.1.0"] # make sure to update supported versions docs when this changes
isCron:
- ${{ github.event_name == 'schedule' }}
Expand Down Expand Up @@ -194,7 +195,8 @@ jobs:

# Based on https://github.com/micromdm/nanomdm/blob/main/.github/workflows/on-push-pr.yml#L87
test-go-nanomdm:
runs-on: 'ubuntu-latest'
# Pinning to 22.04 instead of using ubuntu-latest (updated to 24.04) to fix instability.
runs-on: 'ubuntu-22.04'
services:
mysql:
image: mysql:8.0.36
Expand Down Expand Up @@ -298,7 +300,8 @@ jobs:
# We upload all backend coverage in one step so that we're less like to end up in a situation with a partial coverage report.
upload-coverage:
needs: [test-go, test-go-nanomdm]
runs-on: ubuntu-latest
# Pinning to 22.04 instead of using ubuntu-latest (updated to 24.04) to fix instability.
runs-on: ubuntu-22.04
steps:
- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
Expand Down
Loading