Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add SystemDrive env var to osqueryd if present in orbit" #25239

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Jan 8, 2025

Reverts #2520

Was asked to revert this PR so we can include it in the next release instead

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (e956220) to head (9bb80f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25239      +/-   ##
==========================================
- Coverage   63.85%   63.85%   -0.01%     
==========================================
  Files        1616     1616              
  Lines      153833   153829       -4     
  Branches     3975     3975              
==========================================
- Hits        98224    98221       -3     
+ Misses      47796    47794       -2     
- Partials     7813     7814       +1     
Flag Coverage Δ
backend 64.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo merged commit f7ac65d into main Jan 8, 2025
34 of 36 checks passed
@dantecatalfamo dantecatalfamo deleted the revert-25208-8986-osqueryd-system-drive branch January 8, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants