Tests logging #1602
Merged
Tests logging #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use the inherited stdout/stderr from pytest, like we do for xdg-desktop-portal, xdg-document-portal and xdg-permission-store.
Outputting to stderr makes it show up with all the other messages when running pytest with -s.
GeorgesStavracas
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print everything to stdout/stderr. Currently the logging of all the templates never made it to the output of pytest, and the logging in
tests/__init__.pyends up in a completely different section (the python log capture, instead of the stdout/stderr capture) which makes it hard to tell the order of things.