dynamic-launcher: Ensure $XDG_DATA_HOME/applications exists #1596
+189
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: this portal is missing tests. Someone should write them. |
|
Working on some tests now but it will have to wait until next week. |
The call to g_timeout_add_seconds_full makes the data owned which gets freed when the timeout is removed. Freeing it in the timeout and then removing the timeout is a double-free.
It is possible that the directory has not been created by anything else before which would make dynamic launcher creation fail. Resolves: flatpak#1583
swick
force-pushed
the
wip/dynamic-launcher-mkdir-apps
branch
from
50b3510 to
77a5fa8
Compare
|
Had a bit of time, added a basic test, found a memory leak, a double free and a misleading error message. |
GeorgesStavracas
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the directory has not been created by anything else before which would make dynamic launcher creation fail.
Resolves: #1583