Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move general configuration tab to configuration window first #3655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: move general configuration tab to configuration window first #3655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/config/configwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ ConfigWindow::ConfigWindow(QWidget* parent)
QString modifier =
isDark ? PathInfo::whiteIconPath() : PathInfo::blackIconPath();

// general
m_generalConfig = new GeneralConf();
m_generalConfigTab = new QWidget();
auto* generalConfigLayout = new QVBoxLayout(m_generalConfigTab);
m_generalConfigTab->setLayout(generalConfigLayout);
generalConfigLayout->addWidget(m_generalConfig);
m_tabWidget->addTab(
m_generalConfigTab, QIcon(modifier + "config.svg"), tr("General"));

// visuals
m_visuals = new VisualsEditor();
m_visualsTab = new QWidget();
Expand All @@ -68,14 +77,6 @@ ConfigWindow::ConfigWindow(QWidget* parent)
QIcon(modifier + "name_edition.svg"),
tr("Filename Editor"));

// general
m_generalConfig = new GeneralConf();
m_generalConfigTab = new QWidget();
auto* generalConfigLayout = new QVBoxLayout(m_generalConfigTab);
m_generalConfigTab->setLayout(generalConfigLayout);
generalConfigLayout->addWidget(m_generalConfig);
m_tabWidget->addTab(
m_generalConfigTab, QIcon(modifier + "config.svg"), tr("General"));

// shortcuts
m_shortcuts = new ShortcutsWidget();
Expand Down