Fix tray icon handling on Windows (#2774) #2820
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all tray icon options are ignored on Windows with #ifdefs, which is not needed from functional point of view. This patch removes these restrictions and user is able to decide if tray icon is wanted or not.
Only disadvantage: Since CLI parsing is currently disabled for Windows, users cannot reach the flameshot config GUI anymore after disabling the tray! So one has to edit the ini manually to restore the tray.
flameshot/src/main.cpp
Lines 149 to 153 in 57c8e8d
Disabling the CLI for Windows might not be needed as well. If I find some time, I'll maybe have a look on this and test it (see #2118).