Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition bugs #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transition bugs #12

wants to merge 2 commits into from

Conversation

saymow
Copy link

@saymow saymow commented Jun 21, 2020

These lines will resolve a problem on transitioning, you can notice them when adding some right Icon.

@Jake-Breaks-Stuff
Copy link

⚽ is the html entity for a soccer ball emoji, I think the one you want is actually ›.
Link: https://www.compart.com/en/unicode/U+203A.

Everything else looked great and I added them into my own project.

@saymow
Copy link
Author

saymow commented Jun 24, 2020

It will help you notice what i'm talking about, https://youtu.be/IF6k0uZuypA?t=999
Put slow motion and pay attention on hover effect in each DropdownItem.

This problem occurs because .menu is only affect by the dropdown padding when the transition is finished. Thefore, adding the padding in .menu itself and setting box-sizing: border-box, to not mess up width 100%, solves the issue.

@Jake-Breaks-Stuff
Copy link

Jake-Breaks-Stuff commented Jun 24, 2020

I'm agreeing with your changes. It looks great! I've even implemented them in my own project.
What my issue was is that the html entity you're replacing a chevron with is actually the entity for a soccer ball emoji. Unfortunately, typing either in the comments causes them to render as their entities, so it might have been misunderstood.
The line change on 87 is what I'm referring to.

@saymow
Copy link
Author

saymow commented Jun 24, 2020

lol, im gonna solve this, thank you.

😁

Copy link

@kr4chinin kr4chinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked just fine for me! Thanks 👋🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants