-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition bugs #12
base: master
Are you sure you want to change the base?
Transition bugs #12
Conversation
…hem when adding some right Icon
⚽ is the html entity for a soccer ball emoji, I think the one you want is actually ›. Everything else looked great and I added them into my own project. |
It will help you notice what i'm talking about, https://youtu.be/IF6k0uZuypA?t=999 This problem occurs because .menu is only affect by the dropdown padding when the transition is finished. Thefore, adding the padding in .menu itself and setting box-sizing: border-box, to not mess up width 100%, solves the issue. |
I'm agreeing with your changes. It looks great! I've even implemented them in my own project. |
lol, im gonna solve this, thank you. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked just fine for me! Thanks 👋🏼
These lines will resolve a problem on transitioning, you can notice them when adding some right Icon.