Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localise pytools cache to each runner #3980

Closed
wants to merge 1 commit into from
Closed

Localise pytools cache to each runner #3980

wants to merge 1 commit into from

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Jan 16, 2025 •
edited
Loading

My theory:

Previously we were sharing the pytools cache between runners ($XDG_CACHE_HOME is in the home directory) and so different runners would be clearing it at different times. This may well be the reason for CI times to get so bad when the runners are oversubscribed.

Potentially relevant for thetisproject/thetis#383

@connorjward
Localise pytools cache to each runner
f4fca69 
Previously we were sharing a cache between runners ($XDG_CACHE_HOME is
in the home directory) and so different would be clearing it at
different times.
@connorjward connorjward marked this pull request as ready for review January 16, 2025 17:45
@connorjward connorjward mentioned this pull request Jan 16, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8155 ran7480 passed675 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8149 ran6675 passed1474 skipped0 failed

@connorjward
Copy link
Contributor Author

Actually I don't think that this will help. The runners use containers so do not have access to the same home directory. For reference the container command is

 /usr/bin/docker create --name 843ed855a5bf4e97a632d58e0c780734_firedrakeprojectfiredrakeenvlatest_aec86a --label 2b239b --workdir /__w/firedrake/firedrake --network github_network_865a737a1a724d3e84b5f2a06a533d75  -e "HOME=/github/home" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/github/actions-runner-1a/_work":"/__w" -v "/home/github/actions-runner-1a/externals":"/__e":ro -v "/home/github/actions-runner-1a/_work/_temp":"/__w/_temp" -v "/home/github/actions-runner-1a/_work/_actions":"/__w/_actions" -v "/home/github/actions-runner-1a/_work/_tool":"/__w/_tool" -v "/home/github/actions-runner-1a/_work/_temp/_github_home":"/github/home" -v "/home/github/actions-runner-1a/_work/_temp/_github_workflow":"/github/workflow" --entrypoint "tail" firedrakeproject/firedrake-env:latest "-f" "/dev/null"

in particular note -v "/home/github/actions-runner-1a/_work/_temp/_github_home":"/github/home" - the home directory the runner sees is already isolated.

@connorjward connorjward deleted the connorjward/local-pytools-cache branch January 16, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@connorjward