Preserve default mesh name after Netgen mesh creation #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedAlyLoutfy
changed the title
|
Hello @nbouziani @dham I have created a fix for this issue in this PR, i made it as a draft PR until the CI check passes, I'm waiting approval for the workflows so i can make it ready for review, Thank you. |
connorjward
reviewed
Jan 6, 2025
connorjward
reviewed
Jan 15, 2025
…non-Netgen meshes
connorjward
approved these changes
Jan 15, 2025
|
@MohamedAlyLoutfy I assume that this is ready to merge and no longer a draft? If so please mark as such. |
yes, i made it ready for review so it's no more a draft @connorjward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pointing errors
Description
Root Cause:
The function createFromTopology in ngsPETSc.FiredrakeMesh sets the mesh's name to "Default" regardless of the provided custom or default name. This overwrites the expected mesh.name set during the Firedrake Mesh creation.
Fix Summary:
To preserve the expected mesh.name:
After createFromTopology is called, explicitly reset mesh.name to the desired value (name) to ensure the consistency of the naming conventions.
This ensures that the custom or default name (DEFAULT_MESH_NAME, i.e., "firedrake_default") is maintained after the Netgen mesh is created.