Fixing errors related to default L2 grad in adjoints #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ig-dolci
commented
May 22, 2024
Ig-dolci
commented
May 23, 2024
APaganini
previously requested changes
May 26, 2024
Ig-dolci
commented
May 29, 2024
APaganini
reviewed
May 30, 2024
APaganini
reviewed
May 30, 2024
APaganini
reviewed
May 30, 2024
Ig-dolci
commented
Jun 3, 2024
Ig-dolci
commented
Jun 3, 2024
dham
approved these changes
Jun 5, 2024
Ig-dolci
added a commit
that referenced
this pull request
Jul 6, 2024
Also add test to verify riesz maps for grad adjoints --------- Co-authored-by: Alberto Paganini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks the application of Riesz maps using the L2 norm as the default in Firedrake for adjoint gradients. Implementing this change requires some coding modifications.
Some pyadjoint tests will fail because they were designed with Riesz maps using the l2 norm. To address these test failures, refer to Pyadjoint PR 149, which has the necessary fixes.