-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MassInvPC
subclass AssembledPC
#3372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two comments:
would need to change to:
(of the top of my head, untested) - so a little more unwieldy. |
dham
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tests and we're good.
pbrubeck
force-pushed
the
pbrubeck/cleanup-massinv
branch
from
February 1, 2024 10:11
1b85d20
to
517df4b
Compare
dham
approved these changes
Feb 7, 2024
stephankramer
added a commit
to g-adopt/g-adopt
that referenced
this pull request
Apr 3, 2024
The main reason the have our own version of MassInvPC was that MassInvPC did not update for varying (between solves) viscosities. This has been fixed in firedrakeproject/firedrake#3372 and since then the options structure for the solvers beneath it has changed: need to use pcksp with an additional ksp_ layer now. Thus VariableMassInvPC is no longer a drop in-replacement for MassInvPC as it was intended. Better to stay consistent with Firedrake therefore.
angus-g
pushed a commit
to g-adopt/g-adopt
that referenced
this pull request
Apr 10, 2024
The main reason the have our own version of MassInvPC was that MassInvPC did not update for varying (between solves) viscosities. This has been fixed in firedrakeproject/firedrake#3372 and since then the options structure for the solvers beneath it has changed: need to use pcksp with an additional ksp_ layer now. Thus VariableMassInvPC is no longer a drop in-replacement for MassInvPC as it was intended. Better to stay consistent with Firedrake therefore.
angus-g
pushed a commit
to g-adopt/g-adopt
that referenced
this pull request
Apr 13, 2024
* Remove VariableMassInvPC The main reason the have our own version of MassInvPC was that MassInvPC did not update for varying (between solves) viscosities. This has been fixed in firedrakeproject/firedrake#3372 and since then the options structure for the solvers beneath it has changed: need to use pcksp with an additional ksp_ layer now. Thus VariableMassInvPC is no longer a drop in-replacement for MassInvPC as it was intended. Better to stay consistent with Firedrake therefore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
MassInvPC
subclassAssembledPC