Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Hierarchy support when working with Netgen mesh 2D #3314

Merged
merged 24 commits into from
Feb 7, 2024
Merged

Mesh Hierarchy support when working with Netgen mesh 2D #3314

merged 24 commits into from
Feb 7, 2024

Conversation

UZerbinati
Copy link
Contributor

@UZerbinati UZerbinati commented Jan 10, 2024 •
edited
Loading

Support for 2D multigrid with uniform refinement.
Support for non-uniform degree of curvature.
Test Alfeld split (now via Netgen and not PETSc DMPlexTransform).
Support for Powell-Sabin split (no idea how to test any suggestion would be much appreciated).

@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch from 6df8e58 to db89c1e Compare January 10, 2024 15:18
connorjward
connorjward requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a significant feature. Some documentation is definitely needed.

firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
tests/multigrid/test_netgen_gmg.py Outdated Show resolved Hide resolved
tests/multigrid/test_netgen_gmg.py Show resolved Hide resolved
dham
dham requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs parallel.
Probably needs a SMALL 3d test.
Definitely needs a parallel test.

firedrake/mg/mesh.py Outdated Show resolved Hide resolved
Umberto Zerbinati added 3 commits January 19, 2024 02:15
@UZerbinati UZerbinati marked this pull request as ready for review January 24, 2024 01:52
@UZerbinati
Copy link
Contributor Author

UZerbinati commented Jan 24, 2024 •
edited
Loading

The PR only covers 2D for serial and parallel implementation.
The 3D case requires a bit of work on the Netgen side, which needs to land in Netgen main, so is far in the timeline.
I think the 3D implementation deserves a separate PR.

@UZerbinati UZerbinati changed the title Mesh Hierarchy support when working with Netgen mesh Mesh Hierarchy support when working with Netgen mesh 2D Jan 24, 2024
@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch 5 times, most recently from 4eb4754 to 8e10a97 Compare January 24, 2024 06:55
connorjward
connorjward requested changes Jan 24, 2024
View reviewed changes
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
tests/regression/test_netgen.py Outdated Show resolved Hide resolved
tests/regression/test_netgen.py Show resolved Hide resolved
@connorjward
Copy link
Contributor

These are only minor comments. If you want this merged in the next week please bring it for review at the meeting today. It won't be merged, but if people are generally happy we can merge it once these comments are addressed.

@connorjward
Copy link
Contributor

The PR only covers 2D for serial and parallel implementation. The 3D case requires a bit of work on the Netgen side, which needs to land in Netgen main, so is far in the timeline. I think the 3D implementation deserves a separate PR.

I assume that there is a clear NotImplementedError somewhere if someone tries to do this in 3D? I agree that it does not need to land in this PR.

Umberto Zerbinati and others added 5 commits January 30, 2024 11:49
@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch from 4e7a264 to 99c6151 Compare January 30, 2024 13:19
fix lint
510126c 
Signed-off-by: Umberto Zerbinati <[email protected]>
@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch from 99c6151 to 510126c Compare January 31, 2024 12:26
Better adaptivity test.
d89e747 
Thanks @pef

Signed-off-by: Umberto Zerbinati <[email protected]>
@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch 5 times, most recently from 114c369 to dd07ee6 Compare January 31, 2024 13:47
Fix lint
92006e8 
Signed-off-by: Umberto Zerbinati <[email protected]>
@UZerbinati UZerbinati force-pushed the uzerbinati/netgenHierarchy branch from dd07ee6 to 92006e8 Compare January 31, 2024 13:57
dham
dham requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively minor fixes required.

firedrake/mg/mesh.py Outdated Show resolved Hide resolved
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
tests/multigrid/test_netgen_gmg.py Show resolved Hide resolved
Umberto Zerbinati and others added 8 commits February 2, 2024 17:46
Fix NetgenHierarchy after PR review
cd73c9b 
Signed-off-by: Umberto Zerbinati <[email protected]>
Testing non-uniform degree hierarchy
02a5bfe 
Signed-off-by: Umberto Zerbinati <[email protected]>
Using single function to create netgen mesh
1bbb248 
Signed-off-by: Umberto Zerbinati <[email protected]>
@UZerbinati @dham
Update firedrake/mg/mesh.py
ed0d60f 
Co-authored-by: David A. Ham <[email protected]>
Merge branch 'uzerbinati/netgenHierarchy' of github.com:firedrakeproj…
e44a00a 
…ect/firedrake into uzerbinati/netgenHierarchy

# Conflicts:
#	firedrake/mg/mesh.py
Merge remote-tracking branch 'origin' into uzerbinati/netgenHierarchy
da35700
Testing Alfeld splits as well
01f2661 
Signed-off-by: Umberto Zerbinati <[email protected]>
Clean up and added Alfeld split test
b108cfd 
Signed-off-by: Umberto Zerbinati <[email protected]>
@UZerbinati UZerbinati mentioned this pull request Feb 7, 2024
Merged
Umberto Zerbinati added 2 commits February 7, 2024 12:08
dham
dham reviewed Feb 7, 2024
View reviewed changes
firedrake/mg/mesh.py Outdated Show resolved Hide resolved
@dham dham enabled auto-merge (squash) February 7, 2024 16:33
@dham dham merged commit e8c2a62 into master Feb 7, 2024
10 checks passed
@dham dham deleted the uzerbinati/netgenHierarchy branch February 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward approved these changes

@dham dham dham approved these changes

@rckirby rckirby Awaiting requested review from rckirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UZerbinati @connorjward @dham