DO NOT SQUASH: Specify sparsity block-wise #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
6 times, most recently
from
ee777cc to
6094ccf
Compare
connorjward
requested changes
Jan 4, 2024
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
4 times, most recently
from
f8793f8 to
cfc3c5f
Compare
connorjward
reviewed
Jan 10, 2024
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
from
cfc3c5f to
a9fcc1a
Compare
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
4 times, most recently
from
0eb3b1d to
87bb6e0
Compare
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
9 times, most recently
from
fd42652 to
a585d93
Compare
dham
previously requested changes
Feb 28, 2024
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
2 times, most recently
from
1a27598 to
8ccb56f
Compare
|
Can we merge this and the linked PyOP2 PR? I need to drop branch pointer before merging. |
connorjward
requested changes
Mar 1, 2024
assemble_base_form -> BaseFormAssembler().assemble
_assemble_expr -> ExprAssembler().assemble
allocate_matrix(...) -> get_assembler(...).allocate() get_form_assembler(..., tensor=tensor) -> get_assembler(...).assemble(tensor=tensor)
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
from
8ccb56f to
66baa64
Compare
connorjward
previously approved these changes
Mar 1, 2024
ksagiyam
force-pushed
the
ksagiyam/sparsity
branch
from
66baa64 to
f69a6a8
Compare
|
Thanks. Merged. |
w3168
added a commit
to thwaitesproject/thwaites
that referenced
this pull request
Sep 26, 2024
Probably linked to firedrakeproject/firedrake#3288 where sparsity pattern has changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on OP2/PyOP2#713.