Apply suggestions from code review

Co-authored-by: Connor Ward <[email protected]>

pyop2/types/dat.py

@@ -492,16 +492,18 @@ def norm(self):
         from math import sqrt
         return sqrt(self.inner(self).real)
 
-    def maxpy(self, scalar: list, x: list) -> None:
+    def maxpy(self, scalar: Sequence, x: Sequence) -> None:
         """Compute a sequence of axpy operations.
 
         This is equivalent to calling :meth:`axpy` for each pair of
         scalars and :class:`Dat` in the input sequences.
 
-        :arg scalar: A sequence of scalars.
-        :arg x: A sequence of :class:`Dat`.
-
-        See also :meth:`axpy`.
+        Parameters
+        ----------
+        scalar :
+            A sequence of scalars.
+        x :
+            A sequence of :class:`Dat`.
 
         """
         if len(scalar) != len(x):
@@ -512,7 +514,7 @@ def maxpy(self, scalar: list, x: list) -> None:
     def axpy(self, alpha: float, other: 'Dat') -> None:
         """Compute the operation :math:`y = \\alpha x + y`.
 
-        On this case, `self` is `y` and `other` is `x`.
+        In this case, ``self`` is ``y`` and ``other`` is ``x``.
 
         """
         self._check_shape(other)

pyop2/types/glob.py

@@ -203,16 +203,18 @@ def inner(self, other):
         assert issubclass(type(other), type(self))
         return np.dot(self.data_ro, np.conj(other.data_ro))
 
-    def maxpy(self, scalar: list, x: list) -> None:
+    def maxpy(self, scalar: Sequence, x: Sequence) -> None:
         """Compute a sequence of axpy operations.
 
         This is equivalent to calling :meth:`axpy` for each pair of
         scalars and :class:`Dat` in the input sequences.
 
-        :arg scalar: A sequence of scalars.
-        :arg x: A sequence of :class:`Dat`.
-
-        See also :meth:`axpy`.
+        Parameters
+        ----------
+        scalar :
+            A sequence of scalars.
+        x :
+            A sequence of `Global`.
 
         """
         if len(scalar) != len(x):
@@ -223,7 +225,7 @@ def maxpy(self, scalar: list, x: list) -> None:
     def axpy(self, alpha: float, other: 'Global') -> None:
         """Compute the operation :math:`y = \\alpha x + y`.
 
-        On this case, `self` is `y` and `other` is `x`.
+        In this case, ``self`` is ``y`` and ``other`` is ``x``.
 
         """
         if isinstance(self._data, np.ndarray):