Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Connor Ward <[email protected]>
  • Loading branch information
pbrubeck and connorjward authored Nov 15, 2024
1 parent a07587e commit 2752f93
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions firedrake/pointquery_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,16 +193,18 @@ def predicate(index):


@PETSc.Log.EventDecorator()
def compile_coordinate_element(mesh, contains_eps, parameters=None):
def compile_coordinate_element(mesh: MeshGeometry, contains_eps: float, parameters: dict | None = None):

Check failure on line 196 in firedrake/pointquery_utils.py

View workflow job for this annotation

GitHub Actions / Run linter

F821

firedrake/pointquery_utils.py:196:38: F821 undefined name 'MeshGeometry'
"""Generates C code for changing to reference coordinates.
Parameters
----------
mesh : MeshTopology
mesh :
The mesh.
contains_eps : float
The tolerance used to verify that a point is contained by a cell.
contains_eps :
The tolerance used to verify that a point is contained by a cell.

Check failure on line 205 in firedrake/pointquery_utils.py

View workflow job for this annotation

GitHub Actions / Run linter

W291

firedrake/pointquery_utils.py:205:74: W291 trailing whitespace
parameters :
Form compiler parameters, defaults to whatever TSFC defaults to.
Returns
-------
Expand Down

0 comments on commit 2752f93

Please sign in to comment.