Fix unregistering memory ranges from UFFD when expanding the balloon #4988
+31
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using a UFFD handler to restore a snapshot with a memory balloon, do not mmap anonymous regions over removed addresses.
Reason
We are using a UFFD handler with a memory balloon to track removed which pages were removed in the guest. When an anonymous region is mmapped over the pre-existing one, that region is deregistered from uffd and uffd will no longer receive events for that memory range. (In other words, we would expect UFFD to receive an EVENT_REMOVE for the memory ranges that the balloon has expanded into. However because the memory was remapped, we never receive events for that range.)
Steps to recreate
In this example, when using firecracker v1.10.0, you can see that the UFFD handler never receives any remove events. When using this patched version, the handler will correctly start receiving and handling remove events.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
[
CONTRIBUTING.md
][3].PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.