Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload-artifact actions #1642

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Update upload-artifact actions #1642

merged 4 commits into from
Sep 10, 2024

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Sep 10, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

upload-artifact v2 is deprecated, so update to v3. Note that v3 will be deprecated in a few months, but it has a breaking change where file names have to be unique, which causes enough issues that we need to rethink how some of the actions are laid out.

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Sep 10, 2024
@a-maurice a-maurice changed the title Update actions/upload-artifact to v4 Update upload-artifact and download actions Sep 10, 2024
@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Sep 10, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⏳  Integration test in progress...

Requested by @a-maurice on commit bc9ee6f
Last updated: Tue Sep 10 16:30 PDT 2024
View integration test log & download artifacts

@a-maurice a-maurice changed the title Update upload-artifact and download actions Update upload-artifact actions Sep 10, 2024
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 10, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 10, 2024
@a-maurice a-maurice merged commit bc9ee6f into main Sep 10, 2024
34 of 35 checks passed
@a-maurice a-maurice deleted the am-upload_artifact branch September 10, 2024 23:30
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 10, 2024
@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan