Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging aar path for Unity in CMake #1531

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

In the Messaging CMake we expose the path of the messaging aar for the Unity build to use. Because of the gradle update, the path changed slightly, so we need to update the path.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Building the Unity SDK locally, and on GHA.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jan 31, 2024
@a-maurice a-maurice requested a review from cynthiajoan January 31, 2024 00:25
@a-maurice a-maurice merged commit 5fead53 into main Jan 31, 2024
29 of 47 checks passed
@a-maurice a-maurice deleted the am-messaging_fix branch January 31, 2024 22:39
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

❌  Integration test FAILED

Requested by @a-maurice on commit 5fead53
Last updated: Wed Jan 31 17:12 PST 2024
View integration test log & download artifacts

Failures Configs
firestore [BUILD] [ERROR] [MacOS] [x64] [openssl]
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 1, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 1, 2024
@firebase firebase locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants