-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with linking email to anonymous accounts on desktop #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Dec 12, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Dec 12, 2023
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit 08f43f1
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Dec 12, 2023
a-maurice
added
tests-requested: quick
Trigger a quick set of integration tests.
and removed
tests: failed
This PR's integration tests failed.
labels
Dec 13, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Dec 13, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Dec 13, 2023
a-maurice
added
tests-requested: quick
Trigger a quick set of integration tests.
and removed
tests: failed
This PR's integration tests failed.
labels
Dec 13, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Dec 13, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Dec 13, 2023
a-maurice
added
tests-requested: quick
Trigger a quick set of integration tests.
and removed
tests: failed
This PR's integration tests failed.
labels
Dec 19, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Dec 19, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Dec 19, 2023
jonsimantov
approved these changes
Dec 20, 2023
a-maurice
added
tests: succeeded
This PR's integration tests succeeded.
and removed
tests: failed
This PR's integration tests failed.
labels
Dec 20, 2023
Removing tests failed tag, since it is just caused by backend problems that aren't part of this change |
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: succeeded
This PR's integration tests succeeded.
and removed
tests: succeeded
This PR's integration tests succeeded.
labels
Dec 20, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to email enumeration protection broke some functionality on the backend with email accounts. One of those is upgrading anonymous accounts to have email and password. This can be fixed by using a slightly different rest call, so this makes that change for desktop, mobile platforms will be fixed in the underlying mobile SDKs.
Testing
Testing locally with a custom project that has email enumeration protection turned on.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.