Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android SDK dependency, including updated Gradle and compileSDK version, and including GMA #1473

Merged
merged 32 commits into from
Dec 13, 2023
Merged

Update Android SDK dependency, including updated Gradle and compileSDK version, and including GMA #1473

merged 32 commits into from
Dec 13, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

firebase-workflow-trigger-bot and others added 19 commits October 10, 2023 23:01
Update Android dependencies - Tue Oct 10 2023
a42ea41 
[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/6475704829) by [firebase-android-sdk Oct 10 release](firebase/firebase-android-sdk@a135c51).

  ### Android

- com.google.android.gms.play_services_ads → 22.4.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6475709960).
@jonsimantov
Build GMA with Android 31.
f56b162
@jonsimantov
Increment all gradle wrapper versions to 6.7.1.
3a24508
@jonsimantov
Fix quote in classpath.
d409953
@jonsimantov
Update all gradle plugin versions to 4.2.1.
beb62f9
@jonsimantov
Force NDK path to environment variable for new Gradle version.
0018729
@jonsimantov
Update build tools version.
71bf35e
@jonsimantov
Add gradle.properties with useAndroidX=true flag.
37d9e2f
@jonsimantov
Remove NDK path from unneeded gradle files.
d79e8d2
@jonsimantov
Force name of included C++ SDK build to be firebase_cpp_sdk.
317396b 
This fixes a breaking change in Gradle 6 where included builds
no longer have their name propagated, but instead they use
their path (unless you explicitly set the name, as in this change).
@jonsimantov
Update Firestore internal test also.
8415671
@jonsimantov
Add gradle.properties files.
9a766ea
@jonsimantov
Update readme with new version.
26b3f68
@jonsimantov
Add cleanup directory.
ec1e046
@jonsimantov
Add to .gitignore.
56bfadd
@jonsimantov
Add changed .externalNativeBuild --> .cxx directory to script
f7f8c35 
and ProGuard rules.
@jonsimantov
Revert "Add cleanup directory."
3787b6d 
This reverts commit ec1e046.
@jonsimantov
Add cleanup directory (again).
9762fe9
@jonsimantov
Merge branch 'workflow/auto-update-deps-183-20231010-230135' into try…
1ca875f 
…-gma-with-upgraded-gradle
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 46f1f0b
Last updated: Wed Dec 13 15:41 PST 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: ios_target]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 6, 2023
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Nov 7, 2023
@jonsimantov jonsimantov marked this pull request as ready for review November 7, 2023 01:51
@jonsimantov jonsimantov requested a review from a-maurice November 7, 2023 01:51
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 13, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Dec 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) December 13, 2023 04:11
@jonsimantov
Copy link
Contributor Author

@a-maurice This is ready for review, it has the latest BoM included.

@jonsimantov jonsimantov merged commit 46f1f0b into main Dec 13, 2023
63 of 65 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 13, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2023
@firebase firebase locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice