Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): update CryptoEcon Section content #1158

Merged
merged 8 commits into from
Sep 23, 2020
Merged

Conversation

yiannisbot
Copy link
Collaborator

@yiannisbot yiannisbot commented Sep 17, 2020

This PR is adding new description to the CryptoEconomics section of the spec. The description includes a table with the basic parameters, as well as justification for the design principles of Filecoin's cryptoeconomic model.

TODOs:

  • Link to the minting model and token allocation when the corresponding PRs get merged.
  • There will soon be a separate section that will summarise the parameters of the protocol. Once that section exists, the table included here will likely need to be excluded from here and replace with a pointer to that section, in order to have a single source of truth.

@yiannisbot yiannisbot requested a review from zixuanzh September 17, 2020 06:28
@yiannisbot yiannisbot changed the title major revamp of cryptoecon section CryptoEcon Section Update Sep 17, 2020
@yiannisbot
Copy link
Collaborator Author

The latest commit (6c73b4c) adds a subsection on Verified Clients as part of the CryptoEconomics section. However, given that the term is used earlier in the specification, I have included the same text in an update of the Intro section, currently being worked on in #1168. Given the central role of the term, I don't mind the redundancy, but I also don't mind excluding it in either of the two sections.

@yiannisbot yiannisbot added the scope: content Scope: Editing content of the spec label Sep 21, 2020
@yiannisbot
Copy link
Collaborator Author

Two changes in the latest commits:

  1. it has been decided that the Verified Clients discussion is moved to a separate section of its own.
  2. the cryptoecon parameters have been updated to reflect recommendations on latest values. @zixuanzh please indicate the correct value for the "Sector Termination Fee".

Copy link
Contributor

@zixuanzh zixuanzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiannisbot yiannisbot added the hint: ready to merge Hint: PR is ready to be merged label Sep 23, 2020
@hugomrdias hugomrdias changed the title CryptoEcon Section Update fix(content): update CryptoEcon Section content Sep 23, 2020
@hugomrdias hugomrdias merged commit 0faa3d9 into master Sep 23, 2020
@hugomrdias hugomrdias deleted the cryptoecon-update branch September 23, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants