fix: Fix nested events inside loops leaking memory by referencing the previous 'event_data' when calling the next event on queue #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data' when calling the next event on queue
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1417 1419 +2
Branches 220 220
=========================================
+ Hits 1417 1419 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fgmacedo
changed the title
fgmacedo
force-pushed
the
macedo/fix-recursion-leaking-memory
branch
from
be364ff to
a2f5902
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484.
The
event_dataparameter references theEventDataclass. That is passed askwargsto callbacks that accept this parameter... but all event triggers also acceptevent_data, so after the first loop, the new event receives the previousevent_dataand stores it's reference, making a chain of references for each iteration.Fixed by removing the reference for know kwargs names generated by
EventData.