Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue error & SharedArrayBuffer is not defined #214

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix: vue error & SharedArrayBuffer is not defined #214

merged 2 commits into from
Mar 31, 2022

Conversation

lecepin
Copy link
Member

@lecepin lecepin commented Mar 19, 2022

Fix the following issues #170 #111 #15 .

Please help with code review @vinayakkulkarni.

Xnip2022-03-19_20-08-41

image

@lecepin
Copy link
Member Author

lecepin commented Mar 20, 2022

Hi @vinayakkulkarni ,If there is no problem with the code, can it be merged?

@vinayakkulkarni
Copy link
Member

Hi @vinayakkulkarni ,If there is no problem with the code, can it be merged?

I’ll take a look at the code & test it once tonight and revert

@douglas444
Copy link

douglas444 commented Mar 24, 2022

Hi @vinayakkulkarni ,If there is no problem with the code, can it be merged?

I’ll take a look at the code & test it once tonight and revert

Any progress?

@vinayakkulkarni vinayakkulkarni self-requested a review March 31, 2022 09:42
Copy link
Member

@vinayakkulkarni vinayakkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinayakkulkarni vinayakkulkarni merged commit 075bdd3 into ffmpegwasm:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants