-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a github cron job #478
Conversation
We just got bit by a bug caused by a new release of photutils. Adding a cron job, which will include at least one test with the latest version of dependencies, should help catch this kind of thing in the future.
1922416
to
7798b15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 32 32
Lines 4067 4067
=======================================
Hits 3267 3267
Misses 800 800 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to review this, I see it is a cronjob. but the only lines recorded as changed in the test.yml just are the lines scheduling the job. Is the idea that you want this job to run every when new code hasn't been submitted (to trigger the code review)?
Yes, that would help catch things like the change in photutils... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense.
We just got bit by a bug caused by a new release of photutils. Adding a cron job, which will include at least one test with the latest version of dependencies, should help catch this kind of thing in the future.
This does need to have one job added in tox, I think, that unpins photutils, or maybe runs against a dev version of photutils, before this can be merged