Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github cron job #478

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Oct 27, 2024

We just got bit by a bug caused by a new release of photutils. Adding a cron job, which will include at least one test with the latest version of dependencies, should help catch this kind of thing in the future.

This does need to have one job added in tox, I think, that unpins photutils, or maybe runs against a dev version of photutils, before this can be merged

@mwcraig mwcraig added the tests Issue related to tests label Oct 27, 2024
@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 27, 2024
We just got bit by a bug caused by a new release of photutils. Adding
a cron job, which will include at least one test with the latest version
of dependencies, should help catch this kind of thing in the future.
@mwcraig mwcraig force-pushed the add-github-cron-job branch from 1922416 to 7798b15 Compare November 20, 2024 15:39
@mwcraig mwcraig marked this pull request as ready for review November 20, 2024 15:42
@mwcraig mwcraig requested a review from JuanCab November 20, 2024 15:43
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.32%. Comparing base (b9bf579) to head (7798b15).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files          32       32           
  Lines        4067     4067           
=======================================
  Hits         3267     3267           
  Misses        800      800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review this, I see it is a cronjob. but the only lines recorded as changed in the test.yml just are the lines scheduling the job. Is the idea that you want this job to run every when new code hasn't been submitted (to trigger the code review)?

@mwcraig
Copy link
Contributor Author

mwcraig commented Nov 21, 2024

Yes, that would help catch things like the change in photutils...

@JuanCab JuanCab self-requested a review November 21, 2024 03:57
Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense.

@mwcraig mwcraig merged commit 657b27c into feder-observatory:main Nov 21, 2024
18 checks passed
@mwcraig mwcraig deleted the add-github-cron-job branch November 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issue related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants