Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to calculate BJD from a single coordinate #461

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Oct 7, 2024

This PR fixes #444 by doing two things:

  1. No longer calculating BJD on creation
  2. Adding an argument that allows the coordinates for the correction to be set.

I started out by not doing 1 -- that is, by adding a new parameter to PhotometryData.__init__ but realized that meant, eventually, changing or adding a photometry setting, which I wasn't too enthusiastic about, so I went this route instead.

@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 7, 2024
@mwcraig mwcraig requested a review from JuanCab October 7, 2024 00:15
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (31f01ab) to head (41bddcc).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
stellarphot/core.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   80.30%   80.33%   +0.03%     
==========================================
  Files          30       30              
  Lines        3945     3947       +2     
==========================================
+ Hits         3168     3171       +3     
+ Misses        777      776       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

night

If these computed columns already exist in `data` class the class
will throw an error a ValueError UNLESS`ignore_computed=True`
will throw an error a `ValueError` UNLESS ``ignore_computed=True``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the double backticks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think single backticks is supposed to be a reference and double means format it as code. Not sure why that wasn't an error before, but maybe it was pointing to the attribute?

@mwcraig mwcraig merged commit 2bbc873 into feder-observatory:main Oct 7, 2024
18 checks passed
@mwcraig mwcraig deleted the allow-bjd-frame branch October 7, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BJD calculation is per star, not per frame
2 participants