Replaced financial document icon with new example icon

[rfultz]

Summary

• Resolves Update example icon globally #3602
  Removing the financial icon found on the Advertising and disclaimers page with the icon in the screenshot

Impacted areas of the application

Should only affect references to the img/financial-document-circle.svg, which was only in one place in the repo

Screenshots

Icon in Sketch:

Related PRs

None

How to test

• TODO: duplicate the cms db to localhost to test
• Otherwise, check the Advertising and disclaimers page on dev (linked above)

---

Next steps

Update the pattern library with this new (replacement) icon

[codecov-commenter]

Codecov Report

Merging #3828 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3828      +/-   ##
===========================================
+ Coverage    75.25%   75.27%   +0.01%     
===========================================
  Files          121      121              
  Lines         7352     7352              
  Branches       592      592              
===========================================
+ Hits          5533     5534       +1     
+ Misses        1819     1818       -1     

Impacted Files	Coverage Δ
fec/fec/static/js/modules/calendar.js	92.64% <0.00%> (+0.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d956fc...73a8e4d. Read the comment docs.

[johnnyporkchops]

I think we also need to replace this with an existing or new class for this template option on collection_page.html:

fec-cms/fec/home/templates/home/collection_page.html

Line 58 in 7d956fc

<h2 class="sidebar__title sidebar__title--large icon-heading--financial-document">Reporting examples</h2>

Here is an example of where it is used now:

[rfultz]

Thanks, @johnnyporkchops—good catch! There's a new version on its way to git now

I think we also need to replace this with an existing or new class for this template option on collection_page.html:

fec-cms/fec/home/templates/home/collection_page.html

Line 58 in 7d956fc

<h2 class="sidebar__title sidebar__title--large icon-heading--financial-document">Reporting examples</h2>

Here is an example of where it is used now:

[johnnyporkchops]

@rfultz

• We should keep the icon-heading--financial-document class and create another for example because we do use it some places.
• And it maybe good idea to keep the SVG in statsc/img in case we need it later -- finding the svg or recreating it is kind of a pain.

Apologies for not catching/pointing that out in my review comment! Icons on our site can be confusing.

I think @JonellaCulmer would want us to use icon-heading--financial-document primary for middle circle because its a financial thing (?) On home page:

[JonellaCulmer]

I think @JonellaCulmer would want us to use icon-heading--financial-document primary for middle circle because its a financial thing (?) On home page

@johnnyporkchops You're absolutely right. I didn't even remember that there. My apologies. I thought it would be a clean replacement, but yes, we'll need the financial document to be used there on the homepage.
cc: @rfultz

[patphongs]

Other than keeping the icon-heading--financial-document mentioned by @johnnyporkchops and @JonellaCulmer, everything else looks good

[patphongs]

Thanks for restoring the financial document icon

[johnnyporkchops]

Looks good. Thanks!

[rfultz]

@JonellaCulmer, this is it in the wild:

[JonellaCulmer]

Looks good! Thanks @rfultz