This repository has been archived by the owner on Jul 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: if we put the right tags, tests fail
When replacing
|
=> hypothesis: `!` is not escaped properly
by replacing HTML templating (causing escape to < entities) by Text templates
FYI, here's the vscode configuration we used for debugging, during the hackergarten session:
And the command I ran in my sample $
go get -u github.com/go-delve/delve/cmd/dlv
$ $(go env GOPATH)/bin/dlv --listen=:2345 --headless=true --api-version=2 --accept-multiclient exec $(go env GOPATH)/bin/headache Source: https://github.com/Microsoft/vscode-go/wiki/Debugging-Go-code-using-VS-Code#remote-debugging |
Merged as 72519da, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #22.
Adds
xml
format to add comments surrounded by<!--
and-->
Also fixes a bug with template rendering which was using HTML templating, causing escaping of
<
into<
.