feat: ssh client implement #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizard863
force-pushed
the
feat_ssh_client
branch
from
d25b21a to
2d463cc
Compare
blizard863
force-pushed
the
feat_ssh_client
branch
4 times, most recently
from
e443c8f to
a5a9668
Compare
blizard863
force-pushed
the
feat_ssh_client
branch
2 times, most recently
from
1018de7 to
0724b0f
Compare
blizard863
force-pushed
the
feat_ssh_client
branch
from
0724b0f to
fdd0699
Compare
fatedier
reviewed
Nov 9, 2023
server/ssh_service.go
Outdated
| } | ||
| } | ||
|
|
||
| func parseSSHExtraMessage(s string) (p SSHExtraPayload, err error) { |
There was a problem hiding this comment.
这部分需要看下怎么结合 cobra 来解析，能复用命令行参数解析的代码最好。
server/vclient_service.go
Outdated
| ) | ||
|
|
||
| // VirtualService is a client VirtualService run in frps | ||
| type VirtualService struct { |
There was a problem hiding this comment.
这里的整体设计有问题，把部分 frps 的逻辑放到这里去运行了。
这里应该是一个 VirtualClient，构造一个虚拟的 net.Conn 和 frps 之间交互，然后负责处理和发送 Message。
added 2 commits
November 9, 2023 22:53
blizard863
force-pushed
the
feat_ssh_client
branch
2 times, most recently
from
b2aef87 to
4502159
Compare
blizard863
force-pushed
the
feat_ssh_client
branch
from
4502159 to
40677ce
Compare
fatedier
approved these changes
Nov 14, 2023
| @@ -31,6 +41,9 @@ type ServerConfig struct { | |||
| // BindPort specifies the port that the server listens on. By default, this | |||
| // value is 7000. | |||
| BindPort int `json:"bindPort,omitempty"` | |||
|
|
|||
| SSHTunnelGateway SSHTunnelGateway `json:"sshGatewayConfig,omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| SSHTunnelGateway SSHTunnelGateway `json:"sshGatewayConfig,omitempty"` | |
| SSHTunnelGateway SSHTunnelGateway `json:"SSHTunnelGateway,omitempty"` |
There was a problem hiding this comment.
这个不要放到 pkg/config 下面，应该放到 pkg/ssh 里
fatedier
pushed a commit
that referenced
this pull request
Nov 16, 2023
* feat: frps support ssh * fix: comments * fix: update pkg * fix: remove useless change --------- Co-authored-by: int7 <[email protected]>
fatedier
pushed a commit
that referenced
this pull request
Nov 22, 2023
* feat: frps support ssh * fix: comments * fix: update pkg * fix: remove useless change --------- Co-authored-by: int7 <[email protected]>
fatedier
pushed a commit
that referenced
this pull request
Nov 22, 2023
* feat: frps support ssh * fix: comments * fix: update pkg * fix: remove useless change --------- Co-authored-by: int7 <[email protected]>
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Nov 22, 2023
* https://github.com/fatedier/frp: sshTunnelGateway refactor (fatedier#3784) feat: ssh client implement (fatedier#3671) Fix various typos (fatedier#3783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.