Removed iOS hack related to input focus

+ fixed typo from the previous commit
fancyapps · Apr 9, 2018 · 75abe74 · 75abe74
1 parent c33194d
commit 75abe74
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 64 deletions.
diff --git a/dist/jquery.fancybox.css b/dist/jquery.fancybox.css
@@ -4,13 +4,6 @@ body.compensate-for-scrollbar {
 .fancybox-active {
   height: auto; }
 
-.fancybox-iosfix {
-  height: 100%;
-  left: 0;
-  overflow: hidden;
-  position: fixed;
-  width: 100%; }
-
 .fancybox-is-hidden {
   left: -9999px;
   margin: 0;

diff --git a/dist/jquery.fancybox.js b/dist/jquery.fancybox.js
@@ -1,5 +1,5 @@
 // ==================================================
-// fancyBox v3.3.3
+// fancyBox v3.3.4
 //
 // Licensed GPLv3 for open source use
 // or fancyBox Commercial License for commercial use
@@ -527,18 +527,6 @@
         $container,
         buttonStr;
 
-      // iOS hack; https://bugs.webkit.org/show_bug.cgi?id=176896
-      if (
-        firstItem.type !== "image" &&
-        /iPad|iPhone|iPod/.test(navigator.userAgent) &&
-        !window.MSStream &&
-        !$("body").hasClass("fancybox-iosfix")
-      ) {
-        $("body")
-          .addClass("fancybox-iosfix")
-          .css("top", -$W.scrollTop());
-      }
-
       // Hide scrollbars
       // ===============
 
@@ -2638,14 +2626,6 @@
         $body.removeClass("fancybox-active compensate-for-scrollbar");
 
         $("#fancybox-style-noscroll").remove();
-
-        if ($body.hasClass("fancybox-iosfix")) {
-          scrollTop = parseInt($body[0].style.top, 10);
-
-          $body.css("top", "").removeClass("fancybox-iosfix");
-
-          $W.scrollTop(-scrollTop);
-        }
       }
     },
 
@@ -2765,7 +2745,7 @@
   });
 
   $.fancybox = {
-    version: "3.3.3",
+    version: "3.3.4",
     defaults: defaults,
 
     // Get current instance and execute a command.
@@ -3258,7 +3238,7 @@
           return "&start=" + ((m ? parseInt(m, 10) * 60 : 0) + parseInt(s, 10));
         });
       } else if (providerName === "vimeo") {
-        c = url.replace("&%23", "#");
+        url = url.replace("&%23", "#");
       }
 
       return false;

diff --git a/dist/jquery.fancybox.min.css b/dist/jquery.fancybox.min.css
diff --git a/dist/jquery.fancybox.min.js b/dist/jquery.fancybox.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@fancyapps/fancybox",
   "description": "Touch enabled, responsive and fully customizable jQuery lightbox script",
-  "version": "3.3.3",
+  "version": "3.3.4",
   "homepage": "http://fancyapps.com/fancybox/",
   "main": "./dist/jquery.fancybox.js",
   "author": "fancyApps",

diff --git a/src/css/core.css b/src/css/core.css
@@ -6,14 +6,6 @@ body.compensate-for-scrollbar {
     height: auto;
 }
 
-.fancybox-iosfix {
-    height: 100%;
-    left: 0;
-    overflow: hidden;
-    position: fixed;
-    width: 100%;
-}
-
 .fancybox-is-hidden {
     left: -9999px;
     margin: 0;

diff --git a/src/js/core.js b/src/js/core.js
@@ -517,18 +517,6 @@
         $container,
         buttonStr;
 
-      // iOS hack; https://bugs.webkit.org/show_bug.cgi?id=176896
-      if (
-        firstItem.type !== "image" &&
-        /iPad|iPhone|iPod/.test(navigator.userAgent) &&
-        !window.MSStream &&
-        !$("body").hasClass("fancybox-iosfix")
-      ) {
-        $("body")
-          .addClass("fancybox-iosfix")
-          .css("top", -$W.scrollTop());
-      }
-
       // Hide scrollbars
       // ===============
 
@@ -2628,14 +2616,6 @@
         $body.removeClass("fancybox-active compensate-for-scrollbar");
 
         $("#fancybox-style-noscroll").remove();
-
-        if ($body.hasClass("fancybox-iosfix")) {
-          scrollTop = parseInt($body[0].style.top, 10);
-
-          $body.css("top", "").removeClass("fancybox-iosfix");
-
-          $W.scrollTop(-scrollTop);
-        }
       }
     },
 

diff --git a/src/js/media.js b/src/js/media.js
@@ -163,7 +163,7 @@
           return "&start=" + ((m ? parseInt(m, 10) * 60 : 0) + parseInt(s, 10));
         });
       } else if (providerName === "vimeo") {
-        c = url.replace("&%23", "#");
+        url = url.replace("&%23", "#");
       }
 
       return false;