Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-falcon-talon-chart-pull-secret #821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddrpgmv
Copy link

@ddrpgmv ddrpgmv commented Jan 24, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon-chart

/area event-generator-chart

/area k8s-metacollector-chart

What this PR does / why we need it:
Ability to add a secret(s) to pull falco talon image

Which issue(s) this PR fixes:

Fixes #820

Special notes for your reviewer:

I've already fixed the corrisponding labels in GitHub

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Jan 24, 2025

Welcome @ddrpgmv! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/XS label Jan 24, 2025
@ddrpgmv ddrpgmv force-pushed the fix-falcon-talon-chart-pull-secret branch from 724a049 to 57143ca Compare January 24, 2025 13:11
@Issif Issif self-assigned this Jan 24, 2025
@Issif
Copy link
Member

Issif commented Jan 24, 2025

To be valid, the PR must:

  • update the version of the chart in the Chart.yaml
  • update the values.yaml
  • update the changelog
  • run make docs-falco-talon to update the readme
  • all commits must be signed off

thanks

@ddrpgmv ddrpgmv force-pushed the fix-falcon-talon-chart-pull-secret branch from 57143ca to 4f2bbda Compare January 24, 2025 15:18
@poiana
Copy link
Contributor

poiana commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ddrpgmv
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added size/S and removed size/XS labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define an image pull secret for Falco Talon
3 participants