chore: Add dev container #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #376 Add a Dev Container configuration to the repository. * **Dev Container Configuration** - Add `.devcontainer/devcontainer.json` with configurations for .NET SDK 9, Node LTS, NPM latest, GitHub CLI, Angular CLI, Azure Functions Core Tools, PowerShell, and ESLint. - Include environment variables `ALPACA_KEY`, `ALPACA_SECRET`, and `AzureWebJobsStorage`. * **README.md Updates** - Add instructions for using the Dev Container. - Add instructions for setting up Azure Key Vault for storing secrets. - Add instructions for using User Secrets for local development. * **Project File Updates** - Update `server/Functions/Functions.csproj` and `server/WebApi/WebApi.csproj` to include references to Azure Key Vault SDK and Azure Identity. * **Code Updates** - Update `server/Functions/UpdateQuotes.cs` to retrieve `ALPACA_KEY` and `ALPACA_SECRET` from environment variables, User Secrets, and Azure Key Vault in the recommended order of precedence. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/facioquo/stock-charts/issues/376?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- .devcontainer/devcontainer.json: Language not supported
- server/Functions/Functions.csproj: Language not supported
- server/WebApi/WebApi.csproj: Language not supported
Comments suppressed due to low confidence (5)
server/Functions/UpdateQuotes.cs:46
- [nitpick] The variable name alpacaKey is inconsistently cased compared to the original ALPACA_KEY. It should be renamed to ALPACA_KEY.
string? alpacaKey = _configuration["ALPACA_KEY"];
server/Functions/UpdateQuotes.cs:47
- [nitpick] The variable name alpacaSecret is inconsistently cased compared to the original ALPACA_SECRET. It should be renamed to ALPACA_SECRET.
string? alpacaSecret = _configuration["ALPACA_SECRET"];
server/Functions/UpdateQuotes.cs:65
- The error message for missing Key Vault URL could be more descriptive. Suggested fix: "Key Vault URL is missing. Please set it using
setx KEY_VAULT_URL \"MY-KEY-VAULT-URL\"."
throw new ArgumentNullException(keyVaultUrl, "Key Vault URL missing, use `setx KEY_VAULT_URL \"MY-KEY-VAULT-URL\"` to set.");
server/Functions/UpdateQuotes.cs:81
- The error message for missing API KEY could be more descriptive. Suggested fix: "API KEY is missing. Please set it using
setx ALPACA_KEY \"MY-ALPACA-KEY\"."
throw new ArgumentNullException(alpacaKey, "API KEY missing, use `setx ALPACA_KEY \"MY-ALPACA-KEY\"` to set.");
server/Functions/UpdateQuotes.cs:88
- The error message for missing API SECRET could be more descriptive. Suggested fix: "API SECRET is missing. Please set it using
setx ALPACA_SECRET \"MY-ALPACA-SECRET\"."
throw new ArgumentNullException(alpacaSecret, "API SECRET missing, use `setx ALPACA_SECRET \"MY-ALPACA-SECRET\"` to set.");
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .devcontainer/devcontainer.json: Language not supported
- client/package.json: Language not supported
- client/src/styles.scss: Language not supported
- server/Directory.Packages.props: Language not supported
- server/Functions/Functions.csproj: Language not supported
- server/WebApi/WebApi.csproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
For more details, open the Copilot Workspace session.