Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add notebook rendering style, that sets background as black. #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdmatters
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2021
@cdmatters cdmatters requested a review from heiner June 7, 2021 11:19
@heiner
Copy link
Contributor

heiner commented Jun 7, 2021

I'm confused. This isn't normally how one changes the terminal background (e.g. in iterm2, Konsole, etc).

What's the usecase here?

@cdmatters cdmatters force-pushed the eric/notebook-render branch from f858eb7 to e55f232 Compare June 7, 2021 11:22
@cdmatters
Copy link
Contributor Author

cdmatters commented Jun 7, 2021

I'm confused. This isn't normally how one changes the terminal background (e.g. in iterm2, Konsole, etc).

What's the usecase here?

This is for Jupyter/Colab notebooks.

Libtmt in fact does specify a background color (normally default) but we actually dont collect it in nle.c. We only collect fg and reverse.

@cdmatters cdmatters force-pushed the eric/notebook-render branch from e55f232 to 36f4ee7 Compare June 7, 2021 17:21
@cdmatters cdmatters force-pushed the eric/notebook-render branch from 36f4ee7 to c32a205 Compare June 29, 2021 15:10
@facebook-github-bot
Copy link

Hi @condnsdmatters!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@apowers313 apowers313 mentioned this pull request Aug 13, 2024
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants