--update method name for SensorAttributesManager

facebookresearch · Dec 11, 2024 · ff521f7 · ff521f7
1 parent f9a5fab
commit ff521f7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/esp/metadata/managers/SensorAttributesManager.cpp b/src/esp/metadata/managers/SensorAttributesManager.cpp
@@ -158,7 +158,7 @@ AbstractSensorAttributes::ptr SensorAttributesManager::buildObjectFromJSONDoc(
   return sensorAttributes;
 }  // SensorAttributesManager::buildObjectFromJSONDoc
 
-void SensorAttributesManager::setValsFromJSONDoc(
+void SensorAttributesManager::setValsFromJSONDocInternal(
     AbstractSensorAttributes::ptr attribs,
     const io::JsonGenericValue& jsonConfig) {
   // TODO support loading values from JSON docs for each type of

diff --git a/src/esp/metadata/managers/SensorAttributesManager.h b/src/esp/metadata/managers/SensorAttributesManager.h
@@ -98,15 +98,6 @@ class SensorAttributesManager
       const std::string& filename,
       const io::JsonGenericValue& jsonConfig) override;
 
-  /**
-   * @brief Method to take an existing attributes and set its values from passed
-   * json config file.
-   * @param attribs (out) an existing attributes to be modified.
-   * @param jsonConfig json document to parse
-   */
-  void setValsFromJSONDoc(attributes::AbstractSensorAttributes::ptr attribs,
-                          const io::JsonGenericValue& jsonConfig) override;
-
   /**
    * @brief This function will be called to finalize attributes' paths before
    * registration, moving fully qualified paths to the appropriate hidden
@@ -119,6 +110,16 @@ class SensorAttributesManager
           attributes) const override {}
 
  protected:
+  /**
+   * @brief Internally accessed from AbstractAttributesManager. Method to take
+   * an existing attributes and set its values from passed json config file.
+   * @param attribs (out) an existing attributes to be modified.
+   * @param jsonConfig json document to parse
+   */
+  void setValsFromJSONDocInternal(
+      attributes::AbstractSensorAttributes::ptr attribs,
+      const io::JsonGenericValue& jsonConfig) override;
+
   /**
    * @brief Internal only. Create an attributes from a SensorSpec.
    *