Rename Props.rawProps to Props.dynamicProps #48937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff renames the `rawProps` member of the `Props` class to `dynamicProp`. This is to avoid confusion with the `RawProps` type, since `rawProps` is `folly::dynamic`, not `RawProps`. Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps. Differential Revision: D68633868
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68633868 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 24, 2025
Summary: This diff renames the `rawProps` member of the `Props` class to `dynamicProp`. This is to avoid confusion with the `RawProps` type, since `rawProps` is `folly::dynamic`, not `RawProps`. Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps. Differential Revision: D68633868
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 24, 2025
Summary: This diff renames the `rawProps` member of the `Props` class to `dynamicProp`. This is to avoid confusion with the `RawProps` type, since `rawProps` is `folly::dynamic`, not `RawProps`. Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps. Differential Revision: D68633868
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
Summary: This diff renames the `rawProps` member of the `Props` class to `dynamicProp`. This is to avoid confusion with the `RawProps` type, since `rawProps` is `folly::dynamic`, not `RawProps`. Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps. Differential Revision: D68633868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff renames the
rawPropsmember of thePropsclass todynamicProp.This is to avoid confusion with the
RawPropstype, sincerawPropsisfolly::dynamic, notRawProps.Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps.
Differential Revision: D68633868