-
Notifications
You must be signed in to change notification settings - Fork 202
feature: Add Quarkus generator and health check enricher #1577
Conversation
These are my changes which I added to make Quarkus run out of the box with 4.1 Actually its a bit more (sorry, there has been some changes slipped in, I'm a bit in a hurry):
See also the sample I added. The generator could be improved: Currently, it detects only works when it detects the appropriate jars in target/ to find out the file names. However, since the generators are also run for enriching, and enriching typically happens before compile/package (so no jars are there already), the generator should get the name of the generated jars from the Maven pom. Just had no time to find out, how Quarkus names these jars and how to get it from the pom. |
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
============================================
- Coverage 36.05% 35.94% -0.11%
- Complexity 1128 1130 +2
============================================
Files 181 181
Lines 10021 10067 +46
Branches 1630 1631 +1
============================================
+ Hits 3613 3619 +6
- Misses 5977 6015 +38
- Partials 431 433 +2 |
902de68
to
26af044
Compare
import io.fabric8.maven.core.util.Configs; | ||
import io.fabric8.maven.enricher.api.MavenEnricherContext; | ||
|
||
import static io.fabric8.maven.core.util.Configs.asBoolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import :-)
@@ -22,6 +22,7 @@ | |||
import java.util.Map; | |||
|
|||
import io.fabric8.maven.core.util.Configs; | |||
import io.fabric8.maven.core.util.FileUtil; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
.withParam("-Dquarkus.http.host=0.0.0.0") | ||
.build()) | ||
.workdir("/"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice in my opinion if we keep these values in static constants..
labels.put(BuildLabelAnnotations.VCS_URL.value(), gitRemoteUrl); | ||
} else { | ||
log.warn("Could not detect any git remote"); | ||
if (repository != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Looks awesome 💚
Would really appreciate if you could add a README to your sample on how to try that sample out. I've seen that our samples got outdated with time and most people tend to forget how those samples used to run/what was their purpose.
60b52b5
to
cab69f6
Compare
No description provided.