deps: upgrade cookie, cookie-parser and cookie-session #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
changed the title
wesleytodd
requested changes
Jan 15, 2025
| if (opts.maxAge === null){ | ||
| delete opts.maxAge; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this somehow related to the updates? If so, please document why.
| @@ -36,7 +36,7 @@ | |||
| "body-parser": "^2.0.1", | |||
| "content-disposition": "^1.0.0", | |||
| "content-type": "~1.0.4", | |||
| "cookie": "0.7.1", | |||
| "cookie": "1.0.1", | |||
There was a problem hiding this comment.
@blakeembrey can you comment on this? I believe the breaking changes in 1.x are passed through and so must go out with a major of express, but maybe I am wrong.
| "cookie-parser": "1.4.6", | ||
| "cookie-session": "2.0.0", | ||
| "cookie-parser": "1.4.7", | ||
| "cookie-session": "2.1.0", |
There was a problem hiding this comment.
For all dep updates we are moving to ^ prefixes. This will need to be updated as well, but we prefer doing this in individual commits, so it is unlikely this PR would merge. You may want to open these independently so they can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6103 (comment)