pdk convert + tests

.puppet-lint.rc

@@ -1,3 +1 @@
 --relative
---no-parameter_documentation
---no-params_empty_string

.sync.yml

@@ -0,0 +1,8 @@
+# This file can be used to customize the files managed by PDK.
+#
+# See https://github.com/puppetlabs/pdk-templates/blob/main/README.md
+# for more information.
+#
+# See https://github.com/puppetlabs/pdk-templates/blob/main/config_defaults.yml
+# for the default values.
+--- {}

CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## Release 3.0.0
+
+**Features**
+
+**Bugfixes**
+
+**Known Issues**

data/common.yaml

@@ -0,0 +1 @@
+--- {}

hiera.yaml

@@ -0,0 +1,21 @@
+---
+version: 5
+
+defaults:  # Used for any hierarchy level that omits these keys.
+  datadir: data         # This path is relative to hiera.yaml's directory.
+  data_hash: yaml_data  # Use the built-in YAML backend.
+
+hierarchy:
+  - name: "osfamily/major release"
+    paths:
+        # Used to distinguish between Debian and Ubuntu
+      - "os/%{facts.os.name}/%{facts.os.release.major}.yaml"
+      - "os/%{facts.os.family}/%{facts.os.release.major}.yaml"
+        # Used for Solaris
+      - "os/%{facts.os.family}/%{facts.kernelrelease}.yaml"
+  - name: "osfamily"
+    paths:
+      - "os/%{facts.os.name}.yaml"
+      - "os/%{facts.os.family}.yaml"
+  - name: 'common'
+    path: 'common.yaml'

manifests/check.pp

@@ -18,7 +18,7 @@
   String $hostwide = 'no',
   Variant[String,Integer] $priority  = '50',
   String $project  = 'default',
-  Boolean $enable  = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/configure.pp

@@ -19,7 +19,7 @@
   String $arguments = '',
   Variant[String,Integer] $priority  = '50',
   String $user      = 'root',
-  Boolean $enable   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/deploy.pp

@@ -19,7 +19,7 @@
   String $arguments = '',
   Variant[String,Integer] $priority  = '50',
   String $user      = 'root',
-  Boolean $enable   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/initialize.pp

@@ -17,7 +17,7 @@
   String $arguments = '',
   Variant[String,Integer] $priority  = '50',
   String $user      = 'root',
-  Boolean $enable   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project.pp

@@ -19,7 +19,7 @@
   Optional[String] $source_baseurl = undef,
   String $document_root            = '',
   Optional[String] $config_root    = undef,
-  Boolean $enable                  = true,
+  Variant[Boolean,String] $enable  = true,
 ) {
   require puppi::params
 

manifests/project/archive.pp

@@ -124,7 +124,7 @@
   Boolean $run_checks               = true,
   Boolean $always_deploy            = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/builder.pp

@@ -150,7 +150,7 @@
   Boolean $run_checks               = true,
   Boolean $always_deploy            = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/dir.pp

@@ -123,7 +123,7 @@
   Boolean $run_checks               = true,
   Boolean $skip_predeploy           = false,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/files.pp

@@ -140,7 +140,7 @@
   Variant[String,Integer] $backup_retention    = '5',
   Boolean $run_checks               = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/git.pp

@@ -151,7 +151,7 @@
   Variant[String,Integer] $backup_retention    = '5',
   Boolean $run_checks               = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/hg.pp

@@ -145,7 +145,7 @@
   Variant[String,Integer] $backup_retention    = '5',
   Boolean $run_checks              = true,
   Boolean $auto_deploy             = false,
-  Boolean $enable                  = true,
+  Variant[Boolean,String] $enable  = true,
 ) {
   require puppi
   require puppi::params

manifests/project/maven.pp

@@ -215,7 +215,7 @@
   Boolean $always_deploy            = true,
   Boolean $check_deploy             = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/mysql.pp

@@ -124,7 +124,7 @@
   Boolean $run_checks               = true,
   Boolean $always_deploy            = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/service.pp

@@ -91,7 +91,7 @@
   String $report_email             = '',
   Boolean $run_checks               = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/svn.pp

@@ -169,7 +169,7 @@
   Variant[String,Integer] $backup_retention    = '5',
   Boolean $run_checks              = true,
   Boolean $auto_deploy             = false,
-  Boolean $enable                  = true,
+  Variant[Boolean,String] $enable  = true,
 ) {
   require puppi
   require puppi::params

manifests/project/tar.pp

@@ -137,7 +137,7 @@
   Boolean $always_deploy           = true,
   Boolean $auto_deploy             = false,
   Boolean $verify_ssl              = true,
-  Boolean $enable                  = true,
+  Variant[Boolean,String] $enable  = true,
 ) {
   require puppi
   require puppi::params

manifests/project/war.pp

@@ -139,7 +139,7 @@
   Boolean $always_deploy            = true,
   Boolean $check_deploy             = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/y4maven.pp

@@ -201,7 +201,7 @@
   Boolean $always_deploy            = true,
   Boolean $check_deploy             = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/project/yum.pp

@@ -103,7 +103,7 @@
   Boolean $checks_required          = false,
   Boolean $always_deploy            = true,
   Boolean $auto_deploy              = false,
-  Boolean $enable                   = true,
+  Variant[Boolean,String] $enable   = true,
 ) {
   require puppi
   require puppi::params

manifests/report.pp

@@ -17,7 +17,7 @@
   String $arguments = '',
   Variant[String,Integer] $priority  = '50',
   String $user      = 'root',
-  Boolean $enable    = true,
+  Variant[Boolean,String] $enable = true,
 ) {
   require puppi::params
 

manifests/rollback.pp

@@ -17,7 +17,7 @@
   String $arguments = '',
   Variant[String,Integer] $priority  = '50',
   String $user      = 'root',
-  Boolean $enable   = true,
+  Variant[Boolean,String] $enable = true,
 ) {
   require puppi
   require puppi::params

spec/classes/dependencies_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::dependencies' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/extras_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::extras' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/helpers_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::helpers' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/mcollective/client_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::mcollective::client' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/mcollective/server_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::mcollective::server' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/one_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::one' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/params_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::params' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/puppi_spec.rb

@@ -1,17 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'puppi' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
 
-  let(:node) { 'rspec.example42.com' }
-  let(:node) { 'rspec.example42.com' }
-  let(:facts) { { :ipaddress => '10.42.42.42' } }
-
-  describe 'Test standard installation' do
-    it { should contain_file('puppi').with_ensure('present') }
-    it { should contain_file('puppi.conf').with_ensure('present') }
-    it { should contain_file('puppi.scripts').with_ensure('present') }
-    it { should contain_file('puppi_basedir').with_ensure('directory') }
-    it { should contain_file('puppi_datadir').with_ensure('directory') }
+      it { is_expected.to compile.with_all_deps }
+    end
   end
-
 end

spec/classes/skel_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::skel' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end

spec/classes/two_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'puppi::two' do
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
+
+      it { is_expected.to compile.with_all_deps }
+    end
+  end
+end