Get following siblings for certain nodes #370
Conversation
| } | ||
|
|
||
| // if the child is not in the list of allowed children, throw an error | ||
| if(!targetChildType) throw new Error(`Child ${child} not found in allowed children`); |
There was a problem hiding this comment.
I think we should avoid the use of exceptions, and instead change the return type of the function so the return value is optional.
There was a problem hiding this comment.
Also we should add a test or two for when it returns an empty value.
| // get the index of the child in the list of allowed children and return the following siblings | ||
| const index = childTypes.indexOf(targetChildType); | ||
| // if the childType is a group include it in the list | ||
| if((targetChildType as ChildType).isGroup || !(targetChildType as ChildType).single) return childTypes.slice(index); |
There was a problem hiding this comment.
Split this into multiple lines with braces please.
| } | ||
|
|
||
| // if the child is not in the list of allowed children, throw an error | ||
| if(!targetChildType) throw new Error(`Child ${child} not found in allowed children`); |
There was a problem hiding this comment.
Split this into multiple lines with braces please.
|
|
||
| followingSiblings(child?: string): ChildTypes[] { | ||
| const childTypes = this.static.childTypes; | ||
| if(!child) return childTypes; |
There was a problem hiding this comment.
Split this into multiple lines with braces please.
| }); | ||
|
|
||
| describe('followingSiblings', () => { | ||
| it('get expected children for audio after desc', () => { |
There was a problem hiding this comment.
'get expected children for audio after desc' -> 'get the followingSiblings of desc in the audio element'.
Rename other tests in this fashion too please.
| @@ -194,7 +202,7 @@ export abstract class AbstractBaseNode implements BaseNode { | |||
| return this.canAdd(childNodeName); | |||
| } | |||
|
|
|||
| private canAdd(childNodeName: string): boolean { | |||
| canAdd(childNodeName: string): boolean { | |||
There was a problem hiding this comment.
Why have we changed the visibility of this method? It looks like nothing else in the PR uses this?
There was a problem hiding this comment.
This was a mistake, I will revert it.
| } | ||
|
|
||
| // if the child is not in the list of allowed children, throw an error | ||
| if(!targetChildType) throw new Error(`Child ${child} not found in allowed children`); |
There was a problem hiding this comment.
Also we should add a test or two for when it returns an empty value.
…g siblings of a child node
marmoure
force-pushed
the
feature/folowingsiblings
branch
from
0858629 to
e426141
Compare
marmoure
force-pushed
the
feature/folowingsiblings
branch
from
e426141 to
922a44a
Compare
Create a new function
followingSiblingsto enable getting next possible siblings.