-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting general and CORDEX-Checks, adding further checks #5
Conversation
- added check for DRS path, DRS file name and suffix - generalized reading of CMOR tables
Adding download of miptables similar to euro-cordex/cmor-check
for more information, see https://pre-commit.ci
I can do the the domain coordinates checks! |
- Added check for domain_id - Updated check for unknown variables in file - Added initialization for coordinates (making use of cf_xarray) - Added option to define attributes that will be checked by hand
for more information, see https://pre-commit.ci
- general check of global attributes values against CV - creation_date (global attribute) - version_date / version (DRS path element)
@larsbuntemeyer I think it is in a state that you could have a look. Would be great if you provided some general feedback, also for the "roadmap" sketched above. I am yet uncertain whether dependent checks should generally throw an error when they cannot be conducted or simply should not run (i.e. the frequency cannot be identified, so most of the time checks will either not run or throw errors). I mostly opted for "not running". |
Thanks! I'll have a look asap! |
…attrs) to be checked externally
…atch for CV entries
I think it is straightforward to check the coordinate using the |
I think, this could be merged, if you like. This is lots of new stuff, we can then start from a common code base to tackle all of the rest. |
Sounds good, thanks |
time_range
time_range
calendar
time:units
driving_variant_label
,driving_source_id
anddriving_experiment_id
domain_id
institution
* with * grid spacing *
In further PRs:
crs
:char
orint
, see CF-1.11 Appendix F