Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: resource lock with transfer as the function selector #92

Draft
wants to merge 3 commits into
base: token-lock-hook-module
Choose a base branch
from

Conversation

kanthgithub
Copy link
Contributor

@kanthgithub kanthgithub commented Nov 16, 2024

Description

  • Update the

Motivation and Context

  • CredibleAccountModule will handle resourceLocks via enableSessionKey
  • sessionData contains TokenData[] which holds the token and amount being locked
  • locked tokens are to be transferred to solver who produce the proof-of-execution

Why is this change required? What problem does it solve?

How Has This Been Tested?

  • Unit tests fixed and updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@kanthgithub kanthgithub marked this pull request as draft November 16, 2024 10:11
@kanthgithub kanthgithub changed the title fix: resource lock with transfer as the function selector [WIP] fix: resource lock with transfer as the function selector Nov 16, 2024
- Added some emitted logging for debugging
- Note: some of the tests are now failing so will revert once debugged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants